> -----Original Message-----
> From: Thomas Schwinge <tschwi...@baylibre.com>
> Sent: Tuesday, July 29, 2025 03:46
> To: Robert Dubner <rdub...@symas.com>
> Cc: Jakub Jelinek <ja...@redhat.com>; Richard Biener
> <richard.guent...@gmail.com>; Richard Biener <rguent...@suse.de>;
> jklow...@cobolworx.com; gcc-patches@gcc.gnu.org
> Subject: Re: cobol: [PATCH] Bring the COBOL front end in releases/gcc-15
> up to
> GCC-16
>
> Hi Bob!
>
> On 2025-07-29T09:07:24+0200, Jakub Jelinek <ja...@redhat.com> wrote:
> > On Tue, Jul 29, 2025 at 08:55:05AM +0200, Richard Biener wrote:
> >> > The result of that is the branch "patched15". It has 47
> >> > cherry-picked
> >> > commits on top of gcc/releases/gcc-15. With gcc-15.1.0 as the
> >> > compiler,
> >> > it successfully compiles on an x86_64-linux Ubuntu 22.04 LTS system
> >> > starting from "../configure --enable-languages=all,cobol", meaning it
> >> > is
> a
> >> > bootstrapped multilib build. "make check-cobol" then runs with no
> >> > unexpected errors.
> >> >
> >> > That branch "patched15" can be found at
> >> > https://gitlab.cobolworx.com/COBOLworx/gcc-cobol.git.
> >>
> >> That looks good apart from the pick of 0eac9cfe which brings
> >> in unrelated c/c++ frontend changes for a gcobolspec.cc change.
> >> This rev should be skipped. You can edit it out with a
> >> git rebase -i for example.
> >
> > Yeah, we definitely don't want the -Wunused-but-set-*= changes on
> > the branch.
> > Either drop that commit, or edit it so that it is just the
> > gcc/cobol/gcobolspec.cc
> > cobol change and nothing else, with
> > gcc/cobol/
> > * gcobolspec.cc (lang_specific_driver): Remove unused but set variable
> > n_cobol_files.
> > ChangeLog and edited commit message which just says that it removes
> > an unused variable detected by new GCC 16 warning. Even that can be
> > done
> > with git rebase -i.
>
> In addition to that one, please also drop the empty commit
> "Fix time zone for 'cobol.dg/group2/FUNCTION_DATE___TIME_OMNIBUS.cob'
> [PR119818]"
> (..., which I already had cherry-picked a few weeks ago). You can do
> that also via 'git rebase -i', for example. (..., and remove
> '--allow-empty', '--allow-empty-message', '--keep-redundant-commits' from
> your notes, for next time.)
>
>
> If that wasn't clear: you should then eventually yourself 'git push'
> these changes into releases/gcc-15 branch.
>
>
> Otherwise: glad we got that sorted out! Git is a very powerful tool,
> that takes some training.
>
> I suppose that you were just missing '--reverse' in your 'git rev-list',
> so you got the commits in the wrong order.
Yes, indeed. The documentation for "git rev-list" tricked me.
It says, "The output is given in reverse chronological order by default."
It later says:
" --reverse: Output the commits chosen to be shown in reverse order."
The result is that when one wants the outputs in forward chronological
order, one has to specify "--reverse", meaning "Reverse the reversal."
<grin> Whether or not I should have been led astray by those descriptions
is, I suppose, a matter of opinion.
>
>
> Grüße
> Thomas
