On 24/07/2025 20:13, Tobias Burnus wrote:
Andrew Stubbs wrote:
On 24/07/2025 16:49, Tobias Burnus wrote:
Andrew Stubbs wrote:
On 24/07/2025 14:25, Tobias Burnus wrote:
+/* Device requires CDNA1-style manually inserted wait states for
AVGPRs. */
+#define TARGET_AVGPR_CDNA3_NOPS TARGET_CDNA3
This is not for CDNA1, and not for AVGPRS.
I have deleted it and use now TARGET_CDNA3 directly.
The only thing wrong with what you had before was the name (and the
comment was an unmodified cut-and-paste).
OK, I misunderstood the comment.
+ /* RDNA 2, 3 and 3.5 require no manually inserted wait states. */
+ if (TARGET_RDNA2_PLUS)
+ return;
But, this is another "magic" arch check. Please use a named feature
flag; perhaps "TARGET_MANUALLY_INSERTED_WAIT_STATES".
I went for TARGET_NO_MANUAL_NOPS to be a bit more consistent with the
other names.
Tobias
This is OK now.
Thanks
Andrew
