On Fri, Jul 11, 2025 at 2:51 AM Claudiu Zissulescu-Ianculescu
<claudiu.zissulescu-iancule...@oracle.com> wrote:
>
> Hi,
> >
> >     Currently, the data type of sanitizer flags is unsigned int, with
> >     SANITIZE_SHADOW_CALL_STACK (1UL << 31) being highest individual
> >     enumerator for enum sanitize_code.  Use 'uint64_t' data type to allow
> >     for more distinct instrumentation modes be added when needed.
> >
> >
> >
> > I have not looked yet but does it make sense to use `unsigned
> > HOST_WIDE_INT` instead of uint64_t? HWI should be the same as uint64_t
> > but it is more consistent with the rest of gcc.
> > Plus since tree_to_uhwi is more consistent there.
> >
> That was in the v2, however, the reviewers suggested to use uint64_t.

I see it now from Richard B.. Also I noticed you missed Richard S.'s
suggestion of using a typedef which will definitely help in the future
where we could even replace this with an enum class and overload the
bitwise operators to do the right thing.

Thanks,
Andrew

>
> Best wishes,
> Claudiu

Reply via email to