On Thu, Jul 10, 2025 at 8:13 AM Jakub Jelinek <ja...@redhat.com> wrote:
>
> Hi!
>
> While I'm not a native English speaker, I believe all the uses
> of bellow (roar/bark/...) in comments in gcc are meant to be
> below (beneath/under/...).
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
OK
> 2025-07-10 Jakub Jelinek <ja...@redhat.com>
>
> gcc/
> * tree-vect-loop.cc (scale_profile_for_vect_loop): Comment
> spelling fix: bellow -> below.
> * ipa-polymorphic-call.cc (record_known_type): Likewise.
> * config/i386/x86-tune.def: Likewise.
> * config/riscv/vector.md (*vsetvldi_no_side_effects_si_extend):
> Likewise.
> * tree-scalar-evolution.cc (iv_can_overflow_p): Likewise.
> * ipa-devirt.cc (add_type_duplicate): Likewise.
> * tree-ssa-loop-niter.cc (maybe_lower_iteration_bound): Likewise.
> * gimple-ssa-sccopy.cc: Likewise.
> * cgraphunit.cc: Likewise.
> * graphite.h (struct poly_dr): Likewise.
> * ipa-reference.cc (ignore_edge_p): Likewise.
> * tree-ssa-alias.cc (ao_compare::compare_ao_refs): Likewise.
> * profile-count.h (profile_probability::probably_reliable_p):
> Likewise.
> * ipa-inline-transform.cc (inline_call): Likewise.
> gcc/ada/
> * par-load.adb: Comment spelling fix: bellow -> below.
> * libgnarl/s-taskin.ads: Likewise.
> gcc/testsuite/
> * gfortran.dg/g77/980310-3.f: Comment spelling fix: bellow -> below.
> * jit.dg/test-debuginfo.c: Likewise.
> libstdc++-v3/
> * testsuite/22_locale/codecvt/codecvt_unicode.h
> (ucs2_to_utf8_out_error): Comment spelling fix: bellow -> below.
> (utf16_to_ucs2_in_error): Likewise.
>
> --- gcc/tree-vect-loop.cc.jj 2025-07-09 20:38:59.036628116 +0200
> +++ gcc/tree-vect-loop.cc 2025-07-09 20:42:30.409882136 +0200
> @@ -11489,7 +11489,7 @@ scale_profile_for_vect_loop (class loop
> profile_count entry_count = loop_preheader_edge (loop)->count ();
>
> /* If we have unreliable loop profile avoid dropping entry
> - count bellow header count. This can happen since loops
> + count below header count. This can happen since loops
> has unrealistically low trip counts. */
> while (vf > 1
> && loop->header->count > entry_count
> --- gcc/ipa-polymorphic-call.cc.jj 2025-01-02 20:54:32.263128066 +0100
> +++ gcc/ipa-polymorphic-call.cc 2025-07-09 20:42:00.479269537 +0200
> @@ -1353,7 +1353,7 @@ record_known_type (struct type_change_in
>
> /* If we found a constructor of type that is not polymorphic or
> that may contain the type in question as a field (not as base),
> - restrict to the inner class first to make type matching bellow
> + restrict to the inner class first to make type matching below
> happier. */
> if (type
> && (offset
> --- gcc/config/i386/x86-tune.def.jj 2025-07-09 20:38:58.951629222 +0200
> +++ gcc/config/i386/x86-tune.def 2025-07-09 20:41:41.466515624 +0200
> @@ -31,7 +31,7 @@ see the files COPYING3 and COPYING.RUNTI
> - Updating ix86_issue_rate and ix86_adjust_cost in i386.md
> - possibly updating ia32_multipass_dfa_lookahead, ix86_sched_reorder
> and ix86_sched_init_global if those tricks are needed.
> - - Tunning the flags bellow. Those are split into sections and each
> + - Tunning the flags below. Those are split into sections and each
> section is very roughly ordered by importance. */
>
>
> /*****************************************************************************/
> --- gcc/config/riscv/vector.md.jj 2025-06-30 13:57:47.898657344 +0200
> +++ gcc/config/riscv/vector.md 2025-07-09 20:41:44.100481531 +0200
> @@ -1783,7 +1783,7 @@ (define_insn_and_split "@vsetvl<mode>_no
> [(set_attr "type" "vsetvl")
> (set_attr "mode" "SI")])
>
> -;; This pattern use to combine bellow two insns and then further remove
> +;; This pattern use to combine below two insns and then further remove
> ;; unnecessary sign_extend operations:
> ;; (set (reg:DI 134 [ _1 ])
> ;; (unspec:DI [
> --- gcc/tree-scalar-evolution.cc.jj 2025-05-09 17:56:52.472682248 +0200
> +++ gcc/tree-scalar-evolution.cc 2025-07-09 20:42:16.605060815 +0200
> @@ -3088,7 +3088,7 @@ iv_can_overflow_p (class loop *loop, tre
> type_max = wi::max_value (type);
>
> /* Just sanity check that we don't see values out of the range of the type.
> - In this case the arithmetics bellow would overflow. */
> + In this case the arithmetics below would overflow. */
> gcc_checking_assert (wi::ge_p (base_min, type_min, sgn)
> && wi::le_p (base_max, type_max, sgn));
>
> --- gcc/ipa-devirt.cc.jj 2025-03-03 21:44:09.553931609 +0100
> +++ gcc/ipa-devirt.cc 2025-07-09 20:41:55.212337706 +0200
> @@ -1763,7 +1763,7 @@ add_type_duplicate (odr_type val, tree t
> }
> /* One base is polymorphic and the other not.
> This ought to be diagnosed earlier, but do not ICE in the
> - checking bellow. */
> + checking below. */
> else if (TYPE_BINFO (type1)
> && polymorphic_type_binfo_p (TYPE_BINFO (type1))
> != polymorphic_type_binfo_p (TYPE_BINFO (type2)))
> --- gcc/ada/par-load.adb.jj 2025-01-07 16:37:13.533578824 +0100
> +++ gcc/ada/par-load.adb 2025-07-09 20:41:34.802601876 +0200
> @@ -83,7 +83,7 @@ procedure Load is
> -- withed units and the second round handles Ada 2005 limited-withed
> units.
> -- This is required to allow the low-level circuitry that detects
> circular
> -- dependencies of units the correct notification of errors (see comment
> - -- bellow). This variable is used to indicate that the second round is
> + -- below). This variable is used to indicate that the second round is
> -- required.
>
> function Same_File_Name_Except_For_Case
> --- gcc/ada/libgnarl/s-taskin.ads.jj 2025-01-07 16:37:13.398580711 +0100
> +++ gcc/ada/libgnarl/s-taskin.ads 2025-07-09 20:41:31.225648172 +0200
> @@ -390,7 +390,7 @@ package System.Tasking is
> System_Domain : Dispatching_Domain_Access;
> -- All processors belong to default system dispatching domain at start
> up.
> -- We use a pointer which creates the actual variable for the reasons
> - -- explained bellow in Dispatching_Domain_Tasks.
> + -- explained below in Dispatching_Domain_Tasks.
>
> Dispatching_Domains_Frozen : Boolean := False;
> -- True when the main procedure has been called. Hence, no new
> dispatching
> --- gcc/tree-ssa-loop-niter.cc.jj 2025-01-31 20:23:59.013333149 +0100
> +++ gcc/tree-ssa-loop-niter.cc 2025-07-09 20:42:27.769916307 +0200
> @@ -4701,7 +4701,7 @@ maybe_lower_iteration_bound (class loop
>
> TODO: Due to the way record_estimate choose estimates to store, the
> bounds
> will be always nb_iterations_upper_bound-1. We can change this to
> record
> - also statements not dominating the loop latch and update the walk bellow
> + also statements not dominating the loop latch and update the walk below
> to the shortest path algorithm. */
> for (elt = loop->bounds; elt; elt = elt->next)
> {
> --- gcc/gimple-ssa-sccopy.cc.jj 2025-06-26 09:31:53.761584947 +0200
> +++ gcc/gimple-ssa-sccopy.cc 2025-07-09 20:41:49.240415004 +0200
> @@ -78,7 +78,7 @@ along with GCC; see the file COPYING3.
>
> To find all three types of copy statements we use an algorithm based on
> strongly-connected components (SCCs) in dataflow graph. The algorithm was
> - introduced in an article from 2013[1]. We describe the algorithm bellow.
> + introduced in an article from 2013[1]. We describe the algorithm below.
>
> To identify SCCs we implement the Robert Tarjan's SCC algorithm. For the
> SCC computation we wrap potential copy statements in the 'vertex' struct.
> --- gcc/cgraphunit.cc.jj 2025-03-21 22:40:04.635805495 +0100
> +++ gcc/cgraphunit.cc 2025-07-09 20:41:38.225557570 +0200
> @@ -63,7 +63,7 @@ along with GCC; see the file COPYING3.
> final assembler is generated. This is done in the following way. Note
> that with link time optimization the process is split into three
> stages (compile time, linktime analysis and parallel linktime as
> - indicated bellow).
> + indicated below).
>
> Compile time:
>
> --- gcc/graphite.h.jj 2025-01-02 20:54:32.250128246 +0100
> +++ gcc/graphite.h 2025-07-09 20:41:52.184376901 +0200
> @@ -155,7 +155,7 @@ struct poly_dr
> The OpenScop access function is printed as follows:
>
> | 1 # The number of disjunct components in a union of access functions.
> - | R C O I L P # Described bellow.
> + | R C O I L P # Described below.
> | a s0 s1 i j k 1
> | 1 0 0 0 0 0 -5 = 0
> | 0 1 0 -1 0 0 0 = 0
> --- gcc/ipa-reference.cc.jj 2025-01-02 20:54:32.265128038 +0100
> +++ gcc/ipa-reference.cc 2025-07-09 20:42:03.175234643 +0200
> @@ -732,7 +732,7 @@ get_read_write_all_from_node (struct cgr
> /* Skip edges from and to nodes without ipa_reference enabled.
> Ignore not available symbols. This leave
> them out of strongly connected components and makes them easy to skip in
> the
> - propagation loop bellow. */
> + propagation loop below. */
>
> static bool
> ignore_edge_p (cgraph_edge *e)
> --- gcc/tree-ssa-alias.cc.jj 2025-04-07 21:09:50.027794113 +0200
> +++ gcc/tree-ssa-alias.cc 2025-07-09 20:42:19.766019903 +0200
> @@ -4376,7 +4376,7 @@ ao_compare::compare_ao_refs (ao_ref *ref
> i++;
> }
>
> - /* For variable accesses we can not rely on offset match bellow.
> + /* For variable accesses we can not rely on offset match below.
> We know that paths are struturally same, so only check that
> starts of TBAA paths did not diverge. */
> if (!known_eq (ref1->size, ref1->max_size)
> --- gcc/profile-count.h.jj 2025-07-06 21:31:50.487251519 +0200
> +++ gcc/profile-count.h 2025-07-09 20:42:05.992198182 +0200
> @@ -597,7 +597,7 @@ public:
> There are two exceptions - edges leading to noreturn edges and edges
> predicted by number of iterations heuristics are predicted well. This
> macro
> should be able to distinguish those, but at the moment it simply check
> for
> - noreturn heuristic that is only one giving probability over 99% or
> bellow
> + noreturn heuristic that is only one giving probability over 99% or below
> 1%. In future we might want to propagate reliability information
> across the
> CFG if we find this information useful on multiple places. */
> bool probably_reliable_p () const
> --- gcc/ipa-inline-transform.cc.jj 2025-06-10 23:21:30.953033571 +0200
> +++ gcc/ipa-inline-transform.cc 2025-07-09 20:41:57.601306785 +0200
> @@ -331,7 +331,7 @@ inline_call (struct cgraph_edge *e, bool
> int estimated_growth = 0;
> if (! update_overall_summary)
> estimated_growth = estimate_edge_growth (e);
> - /* This is used only for assert bellow. */
> + /* This is used only for assert below. */
> #if 0
> bool predicated = inline_edge_summary (e)->predicate != NULL;
> #endif
> --- gcc/testsuite/gfortran.dg/g77/980310-3.f.jj 2020-01-14 20:02:48.168589087
> +0100
> +++ gcc/testsuite/gfortran.dg/g77/980310-3.f 2025-07-09 20:42:09.481153017
> +0200
> @@ -12,7 +12,7 @@ C Date: Wed, 17 Dec 1997 23:20:29 +0000
> C From: Joao Cardoso <jcard...@inescn.pt>
> C To: egcs-b...@cygnus.com
> C Subject: egcs-1.0 f77 bug on OSR5
> -C When trying to compile the Fortran file that I enclose bellow,
> +C When trying to compile the Fortran file that I enclose below,
> C I got an assembler error:
> C
> C ./g77 -B./ -fpic -O -c scaleg.f
> --- gcc/testsuite/jit.dg/test-debuginfo.c.jj 2021-09-13 22:33:26.445287969
> +0200
> +++ gcc/testsuite/jit.dg/test-debuginfo.c 2025-07-09 20:42:13.610099582
> +0200
> @@ -1,5 +1,5 @@
> /* Essentially this test checks that debug info are generated for globals
> - locals and functions, including type info. The comment bellow is used
> + locals and functions, including type info. The comment below is used
> as fake code (does not affect the test, use for manual debugging). */
> /*
> int a_global_for_test_debuginfo;
> --- libstdc++-v3/testsuite/22_locale/codecvt/codecvt_unicode.h.jj
> 2025-01-02 20:54:33.021117574 +0100
> +++ libstdc++-v3/testsuite/22_locale/codecvt/codecvt_unicode.h 2025-07-09
> 20:42:35.385817730 +0200
> @@ -1439,7 +1439,7 @@ ucs2_to_utf8_out_error (const std::codec
> // make the trailing surrogate a BMP char
> {5, 10, 3, 6, u'z', 4},
>
> - // don't replace anything in the test cases bellow, just show the
> surrogate
> + // don't replace anything in the test cases below, just show the
> surrogate
> // pair (fourth CP) fully or partially
> {5, 10, 3, 6, u'b', 0},
> {5, 7, 3, 6, u'b', 0}, // no space for fourth CP
> @@ -2072,7 +2072,7 @@ utf16_to_ucs2_in_error (const std::codec
> // make the trailing surrogate a BMP char
> {10, 5, 6, 3, u'z', 4},
>
> - // don't replace anything in the test cases bellow, just show the
> surrogate
> + // don't replace anything in the test cases below, just show the
> surrogate
> // pair (fourth CP) fully or partially (just the first surrogate)
> {10, 5, 6, 3, u'b', 0},
> {8, 5, 6, 3, u'b', 0},
>
> Jakub
>
