On 02/07/25 07:26, Kugan Vivekanandarajah wrote:
Given the latest few patches that you have committed, is this patch necessary
anymore? I have not fully understood the new logic as I was on holiday last
week, but it looks like the propagation is occurring correctly now?
I think you are referring to the patch “Avoid some lost AFDO profiles with LTO”
which introduces pass_ipa_auto_profile_offline. I dont think it does offline
functions !afdo_callsite_hot_enough_for_early_inline. However, it should be
easier now as the early_inline is moved out of auto-profile.
Hmm, I was referring to the "Fix afdo profiles for functions that
was not early-inlined" patch which introduces the
void
autofdo_source_profile::offline_unrealized_inlines ()
function. This seems to merge profiles to offline definitions, and it
is called from the main auto_profile function.
Thanks,
Kugan
--
Regards,
Dhruv
