Hi Jakub,
On Tue, Jul 01, 2025 at 02:50:04PM +0200, Jakub Jelinek wrote:
> Hi!
>
> In Fedora/RHEL we usually test with
> make check RUNTESTFLAGS="--target_board=unix/'{,-fstack-protector-strong}'"
> because -fstack-protector-strong is used when building pretty much all the
> packages.
>
> In the past Marek Polacek has committed tweaks to various tests to make
> them PASS in such testing, see e.g. r14-6276 or r14-2200.
> These 3 tests FAIL with -fstack-protector-strong on s390x because they
> use check-function-bodies and aren't prepared for the extra
> -fstack-protector-{strong,all} extra code in the prologue/epilogue.
In the past years I have started to use more and more function body
checks whenever gcc emits optimal code for a function. With that I
wanted to make sure that we do not regress like introducing unnecessary
extends or whatever which might not have been caught by only testing the
"interesting"/actual part of a patch. Thus, as long as those function
body checks are stable enough, i.e., not subject to insn reordering or
the like, I would like to make use of them in the future, too. That
being said I'm wondering whether it would make sense to automatically
add option -fno-stack-protector for tests which make use function-body
checks? If the testsuite infrastructure doesn't provide this
functionality trivially, I will try to keep this in mind and always add
the option manually.
>
> The following patch should fix that.
>
> Ok for trunk/15.2?
Ok.
Thanks,
Stefan
