On Fri, Jun 27, 2025 at 10:00:00AM GMT, Jakub Jelinek wrote: > On Fri, Jun 27, 2025 at 03:33:35PM +0800, Yang Yujie wrote: > > @@ -11291,6 +11296,13 @@ expand_expr_real_1 (tree exp, rtx target, > > machine_mode tmode, > > type = TREE_TYPE (exp); > > mode = TYPE_MODE (type); > > unsignedp = TYPE_UNSIGNED (type); > > + if (bitint_extended == -1 && TREE_CODE (type) == BITINT_TYPE) > > Please swap the && operands, so > if (TREE_CODE (type) == BITINT_TYPE && bitint_extended == -1) > because not being BITINT_TYPE is going to be far more common. > > Ok for trunk with that nit fixed. > > Jakub
On Fri, Jun 27, 2025 at 10:02:50AM GMT, Jakub Jelinek wrote: > Ok for trunk. Though, a bitintext.h infrastructure test without atomics > that FAILs without this change and passes with it would be really > appreciated. > > Jakub On Fri, Jun 27, 2025 at 10:09:34AM GMT, Jakub Jelinek wrote: > Given the tf stuff here, shouldn't > __fixtfbitint and __floatbitinttf be in the export list next to sf/df? > > Jakub Ok, I will get these fixed. Thanks you for the review. Yujie
