Hi Tomasz and others,
please don't review this. I found some preprequisites I'm not
checking. While implementing the checks for std::extents, I
got saved by one of the tests that exercises the code with an
IntLike (instead of an int).
Therefore, the first task has to be to tighten up the testing
for mdspan. Everything that allows users provided Int, Layout,
etc. needs to be tested with one.
Thank you,
Luc
On 6/11/25 16:09, Tomasz Kaminski wrote:
Hi Luc,
Just to set some expectations, next week we will be participating in C++
committee meeting,
so my availability for review will be limited in the next two weeks.
Regards,
Tomasz
On Wed, Jun 11, 2025 at 3:21 PM Luc Grosheintz <luc.groshei...@gmail.com>
wrote:
This patch completes the C++23 part of <mdspan> and must be applied
after the default_accessor patch.
A question for review: Should we add additional tests, that check
that the implementation works with custom layouts, accessors and
data_handle_types?
It's shared now to allow developers working on linear algebra to
proceed. I'll likely keep working on the tests. Therefore, until
default_accessor has been merged a detailed review might be premature.
Luc Grosheintz (1):
libstdc++: Implement mdspan and tests.
libstdc++-v3/include/std/mdspan | 253 +++++++++++++
libstdc++-v3/src/c++23/std.cc.in | 3 +-
.../23_containers/mdspan/class_mandate_neg.cc | 32 ++
.../testsuite/23_containers/mdspan/mdspan.cc | 348 ++++++++++++++++++
4 files changed, 635 insertions(+), 1 deletion(-)
create mode 100644
libstdc++-v3/testsuite/23_containers/mdspan/class_mandate_neg.cc
create mode 100644 libstdc++-v3/testsuite/23_containers/mdspan/mdspan.cc
--
2.49.0
