I see, thanks Jeff, will make sure the online CI is OK before commit. Pan
-----Original Message----- From: Jeff Law <[email protected]> Sent: Saturday, June 21, 2025 10:32 PM To: Robin Dapp <[email protected]>; Li, Pan2 <[email protected]>; [email protected] Cc: [email protected]; [email protected]; Chen, Ken <[email protected]>; Liu, Hongtao <[email protected]> Subject: Re: [PATCH v1 0/3] RISC-V: Combine vec_duplicate + vsaddu.vv to vsaddu.vx on GR2VR cost On 6/21/25 3:52 AM, Robin Dapp wrote: >> This patch would like to introduce the combine of vec_dup + vsaddu.vv >> into vsaddu.vx on the cost value of GR2VR. The late-combine will take >> place if the cost of GR2VR is zero, or reject the combine if non-zero >> like 1, 2, 15 in test. There will be two cases for the combine: > > OK, thanks. And pre-approval for other operators with the same core implementation where you basically anything where you're adding to those iterators and making the trivial adjustments to the expander & costing and adding testcases. Still let them to through pre-commit testing, but I don't think there's any value in waiting on approval for what's obviously just stamping out new supported operators. jeff
