On 10.06.2025 21:11, Sandra Loosemore wrote:
> On 6/9/25 23:56, Jan Beulich wrote:
>> On 06.06.2025 17:28, Sandra Loosemore wrote:
>>> On 6/6/25 00:44, Jan Beulich wrote:
>>>> As per documentation, even 4.7 ought to suffice. At least 4.13 objects
>>>> to there being nothing ahead of the first comma in @xref{}.
>>>> ---
>>>> The text inserted it merely a guess; I'm open to better suggestions.
>>>>
>>>> Noticed with gcc15, so may want backporting.
>>>>
>>>> --- a/gcc/doc/extend.texi
>>>> +++ b/gcc/doc/extend.texi
>>>> @@ -10667,7 +10667,7 @@ and @samp{[[omp::sequence(...)]]} in C a
>>>> GCC needs to be invoked with the @option{-fopenmp} option.
>>>> This option also arranges for automatic linking of the OpenMP
>>>> runtime library.
>>>> -@xref{,,,libgomp,GNU Offloading and Multi Processing Runtime Library}.
>>>> +@xref{Enabling OpenMP,,,libgomp,GNU Offloading and Multi Processing
>>>> Runtime Library}.
>>>> @xref{OpenMP and OpenACC Options}, for additional options useful with
>>>> @option{-fopenmp}.
>>>> @@ -10689,7 +10689,7 @@ To enable the processing of OpenACC dire
>>>> in C and C++, GCC needs to be invoked with the @option{-fopenacc}
>>>> option.
>>>> This option also arranges for automatic linking of the OpenACC runtime
>>>> library.
>>>> -@xref{,,,libgomp,GNU Offloading and Multi Processing Runtime Library}.
>>>> +@xref{Enabling OpenMP,,,libgomp,GNU Offloading and Multi Processing
>>>> Runtime Library}.
>>>> @xref{OpenMP and OpenACC Options}, for additional options useful with
>>>> @option{-fopenacc}.
>>>
>>> Hmmm, good catch on this. I clearly need to build a libgomp 4.7 manual and
>>> use that for reference instead of the "normal" link at
>>>
>>> https://www.gnu.org/software/texinfo/manual/texinfo/texinfo.html
>>>
>>> which is for the most recent release.
>>>
>>> I think in both places the node name specified as the first argument should
>>> be "Top" -- the reference is intended to be to the libgomp documentation as
>>> a whole, not the specific section about the compilation options.
>>
>> I can do that, albeit libgomp.texi doesn't have a mere "Top" node. It's
>>
>> @node Top, Enabling OpenMP
>>
>> there. Followed later by
>>
>> @node Enabling OpenMP
>> @chapter Enabling OpenMP
>>
>> Please clarify; my texinfo knowledge is pretty limited. Please also clarify
>> if with the adjustments I ought to resend a v2, or whether this is kind of
>> a pre-approval.
>
> The name of the top node is "Top". The optional second argument to
> @node is the name of the node for the "next" pointer.
>
> I am not presently set up to build the GCC documentation with makeinfo
> as old as 4.13, so if you can test that replacing the node name in the
> cross-references with "Top" works, that is fine to check in and backport
> to GCC 15 branch.
Yes, this works as expected. I'll be committing this shortly.
Jan
