Hi FX, I am just wondering if the order in Makefile.am as it is now is needed. E.g. pack_* follows pow_* and some other are not lexicographicaly ordered. Are there dependencies that necessitate this? Or could you just sort them, so that looking up files is easier for humans?
Besides the comment, this looks ok to me. I really like the checks for completeness in the regenerate.sh. I am wondering, if in the future those could be moved to a separate file and be called from a git commit hook to ensure, that changes in the generate are reflected in the commit. Just an idea! Ok for mainline. Thanks for the patch! - Andre On Tue, 10 Jun 2025 12:50:28 +0200 FX Coudert <fxcoud...@gmail.com> wrote: > > the patch looks good to me. I only have x86_64, too, therefore I haven't > > tested it (again). There's a lot of repetition in the regenerate.sh file. I > > hope to see this "simplified" or rather DRY'ed (Don't repeat yourself - > > principle) in the future. > > Following up on this, here is a new patch that simplifies the Makefile logic > a little bit, getting most of the generated files into one big list instead > of many independent variables. This is possible for all except matmul, which > needs its own special flags. > > I also include some checking in the regenerate.sh script, to should make sure > the list of generated files in the script and in the makefile stay in sync. > > Tested on x86_64-linux, OK to push? > > FX > -- Andre Vehreschild * Email: vehre ad gmx dot de
