> This patch introduces a new testcase to verify the merging of profiles > is performed for cloned functions. > > Since this is invoked very early, before the pass manager, we need to > set up the dumping explicitly. This is similar to the handling in > finish_optimization_passes. > > gcc/ChangeLog: > > * auto-profile.cc (autofdo_source_profile::read): Dump message > while merging profile. > * pass_manager.h (get_pass_auto_profile): New. > > gcc/testsuite/ChangeLog: > > * gcc.dg/tree-prof/clone-merge-1.c: New test. > > Is this OK? OK, thanks! It would be nice to also test that some afdo based optimization happens (i.e. have indirect call in the cloned function or so), so we check that the merged data actually works, but having a dump and check that something is done is already good :)
BTW I now see main remaining spec2k17 regresions in omnetpp and imagemagick (small regressions are also in deepsjeng, leela, namd). I plan to investigate them, or do you happen to know what is goind on there? I still test with LTO and post-AFDO cloning disabled. Newly I noticed that the create_gcov tool seems to mishandle partitioned functions, so I also disable function partitioning (which is not on by default on ARM, but I think it would be useful to get it working). Honza > > Thanks, > Kugan >
