Hi!
When reading the code, I've noticed various function definitions
with misaligned parameters, they should IMHO always align below the first
character after opening ( and in most cases they do, but in some
cases they were indented more or less. Perhaps the functions changed
name or something.
Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
2025-06-03 Jakub Jelinek <ja...@redhat.com>
* range-op-float.cc (range_operator::fold_range,
range_operator::op1_range, range_operator::op2_range,
range_operator::lhs_op1_relation, range_operator::lhs_op2_relation,
operator_equal::op1_range, foperator_unordered_gt::op1_range): Fix
up parameter indentation.
* range-op.cc (range_operator::fold_range, range_operator::op1_range,
range_operator::op1_op2_relation_effect,
range_operator::update_bitmask, plus_minus_ranges,
operator_bitwise_and::lhs_op1_relation): Likewise.
--- gcc/range-op-float.cc.jj 2025-06-02 18:10:42.726170068 +0200
+++ gcc/range-op-float.cc 2025-06-02 18:35:27.992962051 +0200
@@ -51,8 +51,8 @@ along with GCC; see the file COPYING3.
bool
range_operator::fold_range (frange &r, tree type,
- const frange &op1, const frange &op2,
- relation_trio trio) const
+ const frange &op1, const frange &op2,
+ relation_trio trio) const
{
if (empty_range_varying (r, type, op1, op2))
return true;
@@ -112,20 +112,20 @@ range_operator::rv_fold (frange &r, tree
bool
range_operator::fold_range (irange &r ATTRIBUTE_UNUSED,
- tree type ATTRIBUTE_UNUSED,
- const frange &lh ATTRIBUTE_UNUSED,
- const irange &rh ATTRIBUTE_UNUSED,
- relation_trio) const
+ tree type ATTRIBUTE_UNUSED,
+ const frange &lh ATTRIBUTE_UNUSED,
+ const irange &rh ATTRIBUTE_UNUSED,
+ relation_trio) const
{
return false;
}
bool
range_operator::fold_range (irange &r ATTRIBUTE_UNUSED,
- tree type ATTRIBUTE_UNUSED,
- const frange &lh ATTRIBUTE_UNUSED,
- const frange &rh ATTRIBUTE_UNUSED,
- relation_trio) const
+ tree type ATTRIBUTE_UNUSED,
+ const frange &lh ATTRIBUTE_UNUSED,
+ const frange &rh ATTRIBUTE_UNUSED,
+ relation_trio) const
{
return false;
}
@@ -142,10 +142,10 @@ range_operator::fold_range (frange &r AT
bool
range_operator::op1_range (frange &r ATTRIBUTE_UNUSED,
- tree type ATTRIBUTE_UNUSED,
- const frange &lhs ATTRIBUTE_UNUSED,
- const frange &op2 ATTRIBUTE_UNUSED,
- relation_trio) const
+ tree type ATTRIBUTE_UNUSED,
+ const frange &lhs ATTRIBUTE_UNUSED,
+ const frange &op2 ATTRIBUTE_UNUSED,
+ relation_trio) const
{
return false;
}
@@ -162,56 +162,56 @@ range_operator::op1_range (frange &r ATT
bool
range_operator::op2_range (frange &r ATTRIBUTE_UNUSED,
- tree type ATTRIBUTE_UNUSED,
- const frange &lhs ATTRIBUTE_UNUSED,
- const frange &op1 ATTRIBUTE_UNUSED,
- relation_trio) const
+ tree type ATTRIBUTE_UNUSED,
+ const frange &lhs ATTRIBUTE_UNUSED,
+ const frange &op1 ATTRIBUTE_UNUSED,
+ relation_trio) const
{
return false;
}
bool
range_operator::op2_range (frange &r ATTRIBUTE_UNUSED,
- tree type ATTRIBUTE_UNUSED,
- const irange &lhs ATTRIBUTE_UNUSED,
- const frange &op1 ATTRIBUTE_UNUSED,
- relation_trio) const
+ tree type ATTRIBUTE_UNUSED,
+ const irange &lhs ATTRIBUTE_UNUSED,
+ const frange &op1 ATTRIBUTE_UNUSED,
+ relation_trio) const
{
return false;
}
relation_kind
range_operator::lhs_op1_relation (const frange &lhs ATTRIBUTE_UNUSED,
- const frange &op1 ATTRIBUTE_UNUSED,
- const frange &op2 ATTRIBUTE_UNUSED,
- relation_kind) const
+ const frange &op1 ATTRIBUTE_UNUSED,
+ const frange &op2 ATTRIBUTE_UNUSED,
+ relation_kind) const
{
return VREL_VARYING;
}
relation_kind
range_operator::lhs_op1_relation (const irange &lhs ATTRIBUTE_UNUSED,
- const frange &op1 ATTRIBUTE_UNUSED,
- const frange &op2 ATTRIBUTE_UNUSED,
- relation_kind) const
+ const frange &op1 ATTRIBUTE_UNUSED,
+ const frange &op2 ATTRIBUTE_UNUSED,
+ relation_kind) const
{
return VREL_VARYING;
}
relation_kind
range_operator::lhs_op2_relation (const irange &lhs ATTRIBUTE_UNUSED,
- const frange &op1 ATTRIBUTE_UNUSED,
- const frange &op2 ATTRIBUTE_UNUSED,
- relation_kind) const
+ const frange &op1 ATTRIBUTE_UNUSED,
+ const frange &op2 ATTRIBUTE_UNUSED,
+ relation_kind) const
{
return VREL_VARYING;
}
relation_kind
range_operator::lhs_op2_relation (const frange &lhs ATTRIBUTE_UNUSED,
- const frange &op1 ATTRIBUTE_UNUSED,
- const frange &op2 ATTRIBUTE_UNUSED,
- relation_kind) const
+ const frange &op1 ATTRIBUTE_UNUSED,
+ const frange &op2 ATTRIBUTE_UNUSED,
+ relation_kind) const
{
return VREL_VARYING;
}
@@ -675,9 +675,9 @@ operator_equal::fold_range (irange &r, t
bool
operator_equal::op1_range (frange &r, tree type,
- const irange &lhs,
- const frange &op2,
- relation_trio trio) const
+ const irange &lhs,
+ const frange &op2,
+ relation_trio trio) const
{
relation_kind rel = trio.op1_op2 ();
switch (get_bool_state (r, lhs, type))
@@ -1871,10 +1871,10 @@ public:
bool
foperator_unordered_gt::op1_range (frange &r,
- tree type,
- const irange &lhs,
- const frange &op2,
- relation_trio) const
+ tree type,
+ const irange &lhs,
+ const frange &op2,
+ relation_trio) const
{
switch (get_bool_state (r, lhs, type))
{
--- gcc/range-op.cc.jj 2025-05-20 08:14:06.000000000 +0200
+++ gcc/range-op.cc 2025-06-02 18:39:20.969965251 +0200
@@ -778,21 +778,21 @@ range_operator::fold_range (irange &r, t
bool
range_operator::fold_range (frange &, tree, const irange &,
- const frange &, relation_trio) const
+ const frange &, relation_trio) const
{
return false;
}
bool
range_operator::op1_range (irange &, tree, const frange &,
- const frange &, relation_trio) const
+ const frange &, relation_trio) const
{
return false;
}
bool
range_operator::op1_range (frange &, tree, const irange &,
- const irange &, relation_trio) const
+ const irange &, relation_trio) const
{
return false;
}
@@ -855,10 +855,13 @@ range_operator::op1_op2_relation (const
bool
range_operator::op1_op2_relation_effect (irange &lhs_range ATTRIBUTE_UNUSED,
- tree type ATTRIBUTE_UNUSED,
- const irange &op1_range ATTRIBUTE_UNUSED,
- const irange &op2_range ATTRIBUTE_UNUSED,
- relation_kind rel ATTRIBUTE_UNUSED) const
+ tree type ATTRIBUTE_UNUSED,
+ const irange &op1_range
+ ATTRIBUTE_UNUSED,
+ const irange &op2_range
+ ATTRIBUTE_UNUSED,
+ relation_kind rel
+ ATTRIBUTE_UNUSED) const
{
return false;
}
@@ -874,7 +877,7 @@ range_operator::overflow_free_p (const i
void
range_operator::update_bitmask (irange &, const irange &,
- const irange &) const
+ const irange &) const
{
}
@@ -1815,7 +1818,7 @@ operator_plus::wi_fold (irange &r, tree
static relation_kind
plus_minus_ranges (irange &r_ov, irange &r_normal, const irange &offset,
- bool add_p)
+ bool add_p)
{
relation_kind kind = VREL_VARYING;
// For now, only deal with constant adds. This could be extended to ranges
@@ -3349,9 +3352,9 @@ wi_optimize_signed_bitwise_op (irange &r
relation_kind
operator_bitwise_and::lhs_op1_relation (const irange &lhs,
- const irange &op1,
- const irange &op2,
- relation_kind) const
+ const irange &op1,
+ const irange &op2,
+ relation_kind) const
{
if (lhs.undefined_p () || op1.undefined_p () || op2.undefined_p ())
return VREL_VARYING;
Jakub
