On Sun, May 25, 2025 at 04:56:48AM +0000, Yuao Ma wrote: > > Thanks for your review! I've updated the patch. > > > this range_check() is unneeded. > > Done. > > > As a side note, the error message is slightly misleading > > (although it will not be issued). Technically, x = -1 or 1 > > are allowed values, and neither is **between** -1 and 1. > > You're right, the original message was a bit imprecise. I've updated this and > five other similar error messages in the patch for better accuracy. >
Thanks for addressing the issues. I looked at the patch in a bit more detail, and I am not thrilled with large-scale whitespace changes mingled with functional changes. It makes the patch harder to read and review. -- Steve
