Hi Jakub, Thank you for your suggestion. I actually learned from your earlier patch (https://gcc.gnu.org/cgit/gcc/commit?id=7f940822) and had already planned to update tree-call-cdce.cc when handling these builtins. Your guidance is much appreciated! Best regards, Yuao
________________________________ From: Jakub Jelinek <ja...@redhat.com> Sent: Saturday, May 17, 2025 22:11 To: Yuao Ma <c...@outlook.com> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; fort...@gcc.gnu.org <fort...@gcc.gnu.org>; tbur...@baylibre.com <tbur...@baylibre.com>; j...@polyomino.org.uk <j...@polyomino.org.uk> Subject: Re: [PATCH] gcc: add trigonometric pi-based functions as gcc builtins On Wed, May 14, 2025 at 02:22:23PM +0000, Yuao Ma wrote: > If approved, I suggest committing this foundational change first. Constant > folding for these builtins will be addressed in subsequent patches. Note, not just constant folding is needed, but I think the builtins should be handled in tree-call-cdce.cc (can_test_argument_range, edom_only_function, get_no_error_domain). Jakub