On Thu, 15 May 2025 at 13:43, Tomasz Kaminski <tkami...@redhat.com> wrote: > > > > On Thu, May 15, 2025 at 2:41 PM Jonathan Wakely <jwak...@redhat.com> wrote: >> >> On 15/05/25 14:35 +0200, Tomasz Kaminski wrote: >> >Please also add the message to dg-error check in format_kind_neg.cc. >> >With that LGTM. >> >> Yes, already done locally. Here's what I'm testing now. > > Any reason to not put the whole message "cannot use primary template of > 'std::format_kind'"?
It doesn't fit in 80 columns, and doesn't seem to make the test any more or less likely to PASS. e.g. if we change the static_assert message to not use single quotes, or to say 'std::format_kind<R>' or some other change, would we want the test to fail and require changes? Would that improve the value of the test? IMHO it doesn't, because if it matches some substring of the static_assert then the test is working correctly, but I'll change it if you feel strongly.
