Hi Kito,

On Mon, May 12, 2025 at 10:17:36PM +0800, Kito Cheng wrote:
> Leverage the centralized riscv-ext.def definitions to auto-generate
> the target option parsing and associated internal flags, replacing
> manual listings in riscv.opt; `riscv_ext_flag_table` part will remove in
> later patch.
> 
> gcc/ChangeLog:
> 
>       * config/riscv/gen-riscv-ext-opt.cc: New.
>       * config/riscv/riscv.opt: Drop manual entries for target
>       options, and include riscv-ext.opt.
>       * config/riscv/riscv-ext.opt: New.
>       * config/riscv/riscv-ext.opt.urls: New.
[...]
>  gcc/config/riscv/riscv-ext.opt.urls       |   0
>  gcc/config/riscv/riscv-opts.h             |  12 +-
>  gcc/config/riscv/riscv-vector-builtins.cc |  20 +-
>  gcc/config/riscv/riscv.opt                | 336 +-----------------
>  gcc/config/riscv/t-riscv                  |  13 +
>  10 files changed, 603 insertions(+), 406 deletions(-)
>  create mode 100644 gcc/config/riscv/gen-riscv-ext-opt.cc
>  create mode 100644 gcc/config/riscv/riscv-ext.opt
>  create mode 100644 gcc/config/riscv/riscv-ext.opt.urls
[...]
> diff --git a/gcc/config/riscv/riscv-ext.opt.urls 
> b/gcc/config/riscv/riscv-ext.opt.urls
> new file mode 100644
> index 000000000000..e69de29bb2d1

This added an empty riscv-ext.opt.urls file.
Which breaks the autoregen builder:
https://builder.sourceware.org/buildbot/#/builders/gcc-autoregen

Because when regenerating this file with make regenerate-opt-urls it
is still empty, but gets an header:

diff --git a/gcc/config/riscv/riscv-ext.opt.urls 
b/gcc/config/riscv/riscv-ext.opt.urls
index e69de29bb2d..c4f471079df 100644
--- a/gcc/config/riscv/riscv-ext.opt.urls
+++ b/gcc/config/riscv/riscv-ext.opt.urls
@@ -0,0 +1,2 @@
+; Autogenerated by regenerate-opt-urls.py from gcc/config/riscv/riscv-ext.opt 
and generated HTML
+

Could you see if you need to add this header or if the file should be
regenerated differently so it isn't empty?

Thanks,

Mark

Reply via email to