On 5/13/25 10:56 AM, Alejandro Colomar wrote:
Hi Jason,
On Tue, May 13, 2025 at 10:35:00AM -0400, Jason Merrill wrote:
It seems to be one of the more common trailers used in the linux
kernel [1],
Hmm, I don't see it in that list. But it is described in
https://docs.kernel.org/process/submitting-patches.html
It was mentioned in one of the replies in that reddit thread, but you
need to click to see more.
"If related discussions or any other background information behind the
change can be found on the web, add ‘Link:’ tags pointing to it. If the
patch is a result of some earlier mailing list discussions or something
documented on the web, point to it."
Why do you "need" it for GCC?
Need is too strong. I think my commit message would be nicer with them.
I could add a paragraph for each link (or maybe several together in
one). But even then, the link breaks the line at some weird point, and
it reads better with a link per line. I don't know; it looks cleaner to
me.
Can't you put a link on its own line without adding "Link:"?
Yes, that's a workaround I used in the past in two of my patches:
11577659949d (2024-10-18; "gcc/: Rename array_type_nelts =>
array_type_nelts_minus_one")
44c9403ed183 (2024-07-14; "c, objc: Add -Wunterminated-string-initialization")
Since these links are presumably to give context to the patch, I'd prefer to
keep them in the upper part of the commit message where that context goes.
Tags at the bottom of the commit are thus after the ChangeLog entries,
separated from the rest of the rationale.
I could live with that. I prefer them in the trailer, but I see your
point. I think they're not essential to understanding the commit
message, and thus find the commit message cleaner without them, but
that's just an opinion. In other cases, it might be different (I
sometimes inline links in the commit message, when I consider it part of
the rationale).
You can even add Link: to the links if you feel like it, as long as they
come before the ChangeLog.
Yep, that's what I did to workaround the limitations of the script in
the past. I could live with it if you prefer it like that.
I think that's my preference.
Jason
