Hi Yuao,
Yuao Ma wrote:
I'm writing to express my sincere gratitude for the opportunity to
participate
in Google Summer of Code with GCC this year. I am very enthusiastic
about this
program and fully committed to making a valuable contribution and
fulfilling my
responsibilities.
Welcome and thanks for participating! And sorry for not coming back to
you earlier!
As I am relatively new to submitting patches via mailing lists, I
would like to
send a very simple patch primarily to familiarize myself with the correct
procedure. I have reviewed the contribution guidelines on the GCC
website and
have tried to follow them closely.
Looks quite good, just a few remarks:
* This is a trivial patch but for larger patches, you need
grant the right to use your patch. There are two ways of doing so:
(a) The simple one, called "Developer Certificate of Origin" (DCO).
This requires a "Signed-off-by:" line (as added by 'git commit -s'.
(b) A copyright assignment with the Free Software Foundation (FSF).
See https://gcc.gnu.org/contribute.html and for the DCO variant
in particular: https://gcc.gnu.org/dco.html for details and for
what you actually certify/grant.
* Regarding the ChangeLog in the email:
(a) FYI - if you run for the last commit
./contrib/gcc-changelog/git_check_commit.py -v -p or for some commit
./contrib/gcc-changelog/git_check_commit.py -v -p <git-hash> Then you
see how the resulting ChangeLog will look like - it also shows errors
and warnings. (That's also used on the server.) (b) Small nit picking:
Subject: [PATCH] Fix simple typo in libgfortran
libgfortran/ChangeLog:
* io/read.c: typo fix, explict -> explicit
If applicable, the function name is put in parentheses after
the file name, i.e.:
* io/read.c (read_f): ... Additionally, per style convention, the entry starts with a
captial letter '... (read_f): Typo ...' - and it ends with a full stop
'.' Otherwise, I would use 'comment typo' to make clear that it is just
in a comment (and not, e.g., in some diagnostic output). But that's
really only a small personal preference. * * * Thanks again for the
patch and welcome again :-) Tobias
