Hi Robert,
>> -----Original Message-----
>> From: Rainer Orth <r...@cebitec.uni-bielefeld.de>
>> Sent: Friday, April 11, 2025 05:26
>> To: gcc-patches@gcc.gnu.org
>> Cc: Robert Dubner <rdub...@symas.com>; James K. Lowden
>> <jklow...@cobolworx.com>
>> Subject: [PATCH] libgcobol: Heed --enable-libgcobol
>>
>> If some target isn't listed as supported in configure.tgt,
>> --enable-libgcobol cannot override that. However, that's what should
>> happen just like an explicit --enable-languages=cobol forces the
>> frontend to be built.
>>
>> This patch, shamelessly adapted from libphobos, does just that.
>>
>> Tested on amd64-pc-solaris2.11, sparcv9-sun-solaris2.11, and
>> x86_64-pc-linux-gnu.
>>
>> Ok for trunk?
>
> I was unable to apply this patch. "git apply ..." results in
>
> :~/repos/gcc-cobol$ git apply libgcobol-enable-libgcobol.patch
> error: patch failed: libgcobol/configure:788
> error: libgcobol/configure: patch does not apply
> error: patch failed: libgcobol/configure.ac:40
> error: libgcobol/configure.ac: patch does not apply
>
> I don't understand the problem, but I don't know much about how diff and
> apply work.
That's my fault actually: I had rebased the patch locally a few times
since submission due to upstream changes to libgcobol/configure.ac.
However, since the gist of the patch wasn't affected by those, I'd
neglected to post those rebased versions.
> I have no way of checking the solaris part of it; I was just trying to do
> "due diligence", and check that it didn't adversely affect x86_64-linux-gnu.
You'd have been able to verify it on every target not currently marked
as supported in libgcobol/configure.tgt, actually. I'd already run
bootstraps with it on Linux/x86_64 just to make sure nothing breaks.
> But since I can't do that, all I can say is, I see no reason for you not to
> apply a patch you know works.
Thanks. All four patches have been committed now.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
