On Thu, May 1, 2025 at 10:35 PM Mark Wielaard <m...@klomp.org> wrote:
>
> Hi Richard,
>
> On Mon, Apr 28, 2025 at 11:26:50AM +0200, Richard Biener wrote:
> > On Tue, Feb 18, 2025 at 1:44 PM Richard Biener <rguent...@suse.de> wrote:
> > >
> > > The following changes how flag_complex_method is managed towards
> > > being able to record that in the optimization set so we can stream
> > > and restore it per function. Currently -fcx-fortran-rules and
> > > -fcx-limited-range are separate recorded options but saving/restoring
> > > does not restore flag_complex_method which is later used in the
> > > middle-end.
> > >
> > > The solution is to make -fcx-fortran-rules and -fcx-limited-range
> > > aliases of a new -fcx-method= switch that represents flag_complex_method
> > > directly so we can save and restore it.
> > >
> > > Bootstrap and regtest running on x86_64-unknown-linux-gnu. How do
> > > we go about documenting Aliased flags? I'm hoping for test coverage
> > > of language-specific defaults.
> > >
> > > We allowed inlining of -fcx-limited-range into -fno-cx-limited-range
> > > (but failed to check -fcx-fortran-rules). Such inlining would
> > > pessimize complex multiplication/division, but I've preserved this
> > > behavior and properly based it on flag_complex_method.
> > >
> > > OK for stage1?
> >
> > I have pushed this now.
>
> This breaks the autoregen bot because gcc/common.opt.urls wasn't
> regenerated. https://builder.sourceware.org/buildbot/#/builders/269
Fixed.
I wonder if we can somehow arrange build to complain, like we do for
tm.texi{,.in}
Richard.
> Fix is trivial:
>
> diff --git a/gcc/common.opt.urls b/gcc/common.opt.urls
> index 00775118e6f..c1085608735 100644
> --- a/gcc/common.opt.urls
> +++ b/gcc/common.opt.urls
> @@ -502,6 +502,9 @@
> UrlSuffix(gcc/Optimize-Options.html#index-fcse-follow-jumps)
> fcse-skip-blocks
> UrlSuffix(gcc/Optimize-Options.html#index-fcse-skip-blocks)
>
> +fcx-method=
> +UrlSuffix(gcc/Optimize-Options.html#index-fcx-method)
> +
> fcx-limited-range
> UrlSuffix(gcc/Optimize-Options.html#index-fcx-limited-range)
>
>
> Cheers,
>
> Mark
