On Tue, Apr 22, 2025 at 12:11 AM Martin Jambor <mjam...@suse.cz> wrote: > > Hi, > > On Thu, Apr 17 2025, Andrew Pinski wrote: > > Here we had: > > node = node; > > Which does nothing so let's remove it. > > > > gcc/ChangeLog: > > > > * ipa-icf.cc (sem_function::init): Remove assignment of node from > > itself. > > I'm not sure if you meant to push this as obvious or whether you were > looking for an approval. In the latter case, please go ahead and commit > the patch.
I was looking for approval since I was not 100% sure I was not missing something. Note I am going to wait until GCC 15.1.0 is out the door before pushing this one. Thanks, Andrew Pinski > > Thanks, > > Martin > > > > > > Signed-off-by: Andrew Pinski <quic_apin...@quicinc.com> > > --- > > gcc/ipa-icf.cc | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/gcc/ipa-icf.cc b/gcc/ipa-icf.cc > > index 3fccc620a82..c273032cae2 100644 > > --- a/gcc/ipa-icf.cc > > +++ b/gcc/ipa-icf.cc > > @@ -1367,7 +1367,6 @@ sem_function::init (ipa_icf_gimple::func_checker > > *checker) > > gcc_assert (SSANAMES (func)); > > > > ssa_names_size = SSANAMES (func)->length (); > > - node = node; > > > > decl = fndecl; > > region_tree = func->eh->region_tree; > > -- > > 2.43.0
