On Tue, Mar 25, 2025 at 03:44:51PM +0800, Hu, Lin1 wrote:
> Hi, all
>
> This patch aims to add "s_" after 'cvt' represent saturation.
>
> Bootstrapped and regtested on x86_64-linux-gnu-{-m32,-m64}, OK for trunk?
>
> BRs,
> Lin
>
> gcc/ChangeLog:
>
> * config/i386/avx10_2-512convertintrin.h: Modify intrin name.
> * config/i386/avx10_2convertintrin.h: Ditto.
Not a review, just nits. This is not correct ChangeLog entry.
You didn't say which names were changed and to what.
Furthermore, there were some other changes as well.
So it should be more like
* config/i386/avx10_2-512convertintrin.h (_mm512_mask_cvtx2ps_ph,
_mm512_mask_cvtx_round2ps_ph, _mm512_maskz_cvtx_round2ps_ph):
Formatting fixes.
(_mm512_mask_cvtbiassph_bf8): Rename to ...
(_mm512_cvts_biasph_bf8): ... this.
etc.
People grep the ChangeLog files for exact function names and a point where
a function changes name is definitely what they sometimes want to find.
Modify intrin name. will not be found.
Jakub
