> On 18 Mar 2025, at 01:27, Andrew Pinski <quic_apin...@quicinc.com> wrote:
>
> So what is happening is gcc_cv_ld64_macosx_version_min is being
> used for the replacement and being set in a few locations but
> gcc_cv_ld64_macos_version_min is set in others.
> Since the auto-host.h variable is named LD64_HAS_MACOS_VERSION_MIN,
> I changed over to remove the x from the name.
>
> Committed as obvious after a quick test to make sure
> LD64_HAS_MACOS_VERSION_MIN
> was not set to empty.
Thanks - I did not spot this in my testing, I think because I always build with
a linker available.
ld64 used to accept -macosx_version_min to pass the OS version, it was changed
recently
to accept ‘-macos_version_min’ and it is very easy to typo.
It would have been nice if Apple had dropped the tautologous “X” from macOS
when they
transitioned to ’11’ … and it was discussed - but I guess “macosx” is too
deeply embedded
in the toolchains - so the ld64 change is, I think, the only one.
thanks
Iain
