Hello,

Sandeep Soni <soni.sande...@gmail.com> a écrit:

> Hi Diego,
>
> The following patch recognizes function declarations. I am now trying
> to create a gimple sequence of all the statements within the function
> body.
> The chagelog is as follows:
>
> 2012-07-31   Sandeep Soni <soni.sande...@gmail.com>
>
>       * parser.c (gl_token_starts_decl): Modify. Matches function decls.
>       (gp_parse_parm_decl): New.
>       (gp_parse_return_type): New.
>       (gp_parse_function_decl): New.
>       (gp_parse_decl): Modify. Adds case for function decls.

Just a random note.

For casual patch readers like myself, it would be nice to have test
cases added to commits like this, so that we have a better idea of the
syntax we are parsing against.

The functions are greatly commented in the patch, which helps, but I
think having test cases would be even better.

Thanks.

-- 
                Dodji

Reply via email to