> -----Original Message-----
> From: Simon Martin <si...@nasilyan.com>
> Sent: Wednesday, March 12, 2025 06:27
> To: gcc-patches@gcc.gnu.org
> Cc: rdub...@symas.com
> Subject: [PATCH] cobol: Remove unnecesssary CPPFLAGS update and restore
> MacOS build
>
> The build currently fails on MacOS even when the Cobol front-end and
> libgcobol builds are disabled.
>
> The problem is that gcc/cobol/Make-lang.in adds -Iinclude to CPPFLAGS,
> which somehow makes clang unhappy about the include order:
> error: <cstddef> tried including <stddef.h> but didn't find libc++'s
> <stddef.h> header. This usually means that your header search paths
> are not configured properly.
>
> It turns out that this addition is unnecessary: simply removing it fixes
> the build on MacOS, without impacting the build x86_64-pc-linux-gnu when
> configured with --enable-languages=default,cobol.
>
> It feels like there might be more cleanup opportunities there, but they
> can be taken care of later.
>
> OK for trunk?
I am still trying to get up to speed, here. Jim and I have been living in
our tidy little world; he's been developing in an Ubuntu instances on a
aarch64 Mac M2, and I've been developing on an Ubuntu environment on a
x86_64.
But now we've gotten off the train at Grand Central Station, and I feel
like there are cars whizzing by, and horns honking, and pedestrians
pushing past me muttering, "Brush the hay out of your hair!"
So, if I am supposed to answer that question, and if indeed the change
doesn't affect x86_64-pc-linux-gnu builds, then by all means, it is "OK
for trunk".
We'll deal with any downstream problems later; right now Jim and I are
very sensitive to the goal of "Don't break the build".
>
> gcc/cobol/ChangeLog:
>
> * Make-lang.in: Remove unnecessary CPPFLAGS update.
>
> ---
> gcc/cobol/Make-lang.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gcc/cobol/Make-lang.in b/gcc/cobol/Make-lang.in index
> a4e005ac2bd..7888c116d70 100644
> --- a/gcc/cobol/Make-lang.in
> +++ b/gcc/cobol/Make-lang.in
> @@ -56,7 +56,6 @@ LIB_SOURCE ?= $(srcdir)/../libgcobol #
> CPPFLAGS = \
> -std=c++14 \
> - -Iinclude \
> -I$(BINCLUDE) \
> -I$(LIB_INCLUDE) \
> -DEXEC_LIB=\"$(prefix)/lib64\" \
> --
> 2.44.0
