On Fri, 14 Feb 2025, Jakub Jelinek wrote: > --- gcc/testsuite/c-c++-common/attr-nonstring-9.c.jj 2025-02-13 > 16:32:38.375848629 +0100 > +++ gcc/testsuite/c-c++-common/attr-nonstring-9.c 2025-02-14 > 10:58:08.557320758 +0100 > @@ -0,0 +1,51 @@ > +/* Test to exercise attribute "nonstring" syntax. > + { dg-do compile } > + { dg-options "-Wattributes" } */ > + > +#define ATTR(list) __attribute__ (list) > +#define NONSTR ATTR ((nonstring)) > + > +/* Verify it's accepted on char[] arrays. */ > +extern NONSTR char nsx_1[][3]; > +extern char NONSTR nsx_2[][3]; > +extern char nsx_3[][3] NONSTR; > + > +extern NONSTR char ns1[1][4]; > +extern char NONSTR ns3[3][5]; > +extern char ns5[5][6] NONSTR; > + > +extern NONSTR char ns4[1][2][3][4]; > +extern char NONSTR ns5[2][3][4][5][6]; > +extern char ns6[1][2][3][1][2][3][1][2][3];
This declaration of ns6 looks like it was intented to have NONSTR somewhere, maybe at the end, since otherwise it's not clear why it's in this test at all. The patch is OK with that change. -- Joseph S. Myers josmy...@redhat.com