On Thu, 6 Mar 2025 at 14:28, Thomas Schwinge wrote: > > In a '-fno-exceptions' configuration: > > In file included from > ../../../../../source-gcc/libstdc++-v3/src/c++20/format.cc:29: > [...]/build-gcc/[...]/libstdc++-v3/include/format: In function ‘void > std::__throw_format_error(const char*)’: > [...]/build-gcc/[...]/libstdc++-v3/include/format:200:36: error: unused > parameter ‘__what’ [-Werror=unused-parameter] > 200 | __throw_format_error(const char* __what) > | ~~~~~~~~~~~~^~~~~~ > > libstdc++-v3/ > * include/bits/c++config [!__cpp_exceptions] > (_GLIBCXX_THROW_OR_ABORT): Reference '_EXC'. > > Co-authored-by: Jonathan Wakely <jwak...@redhat.com>
Hmm, I didn't like this change (my original review said "I don't think we want/need this at all, but it could be done like this...") and it turns out that it causes diagnostic regressions. The problem is in the front-end so I've filed it as https://gcc.gnu.org/PR119149 I think we can live with the diagnostic regressions, since it's only for code that's ill-formed anyway, and only for -fno-exceptions.