On 2/20/25 8:11 AM, jeevitha wrote:
> The following patch has been bootstrapped and regtested on powerpc64le-linux.
A note for the future:
1) When sending a V2, V3, ... patch, please send it as its own email
thread, meaning, don't hit reply to a previous patch version email,
since that tends to put them into the same email thread. I know Segher's
MUA sorts those differently and your submission might not be seen.
2) Please add a Changes from V1, etc. lines to your V2, V3, etc. patches,
so we can see what changed from the previous patch(es), which makes
reviewing your V2, V3, etc. patches easier. Something like:
Changes from V2:
* Added blah blah
* Removed blah blah
Changes from V1:
* Modified blah blah
* Rebase to current trunk.
* etc.
> Changes to amo.h include the addition of the following load atomic operations:
> Compare and Swap Not Equal, Fetch and Increment Bounded, Fetch and Increment
> Equal, and Fetch and Decrement Bounded. Additionally, Store Twin is added for
> store atomic operations.
I mentioned offline I had some questions about the V2 patch, but after looking
closer at the patch, it was a misunderstanding on my part of what part of the
patch was doing. ...meaning, the code changes in the patch LGTM, modulo some
white space issues:
> * doc/extend.texi (PowerPC Atomic Memory Operation Functions):
> Document new functions.
There should be a tab in front of "Document new functions." line, rather than
8 consecutive spaces.
> * gcc.target/powerpc/amo6.c: Likewise.
> * gcc.target/powerpc/amo7.c: Likewise.
Both of these test cases have multiple 8 consecutive spaces that should
be converted to tabs too.
Otherwise, LGTM. We just need Segher's approval now.
Peter
