On Thu, 2025-02-13 at 09:24 +0800, Lulu Cheng wrote:
>
> 在 2025/2/12 下午6:19, Xi Ruoyao 写道:
> > On Wed, 2025-02-12 at 18:03 +0800, Lulu Cheng wrote:
> >
> > /* snip */
> >
> > > diff --git a/gcc/testsuite/gcc.target/loongarch/pr118828-3.c
> > > b/gcc/testsuite/gcc.target/loongarch/pr118828-3.c
> > > new file mode 100644
> > > index 00000000000..a682ae4a356
> > > --- /dev/null
> > > +++ b/gcc/testsuite/gcc.target/loongarch/pr118828-3.c
> > > @@ -0,0 +1,55 @@
> > > +/* { dg-do run } */
> > > +/* { dg-options "-march=loongarch64" } */
> > > +
> > > +#include <string.h>
> > > +#include <stdio.h>
> > > +#include <stdlib.h>
> > > +
> > > +#ifndef __loongarch_arch
> > > +#error __loongarch_arch should not be available here
> > > +#endif
> > Hmm this seems not correct? __loongarch_arch should be just
> > "loongarch64" here (at least it is "loongarch64" with GCC <= 14).
>
> Well, because this predefined macro must be defined in any case, I added
> this check here.
>
> But it seems a bit redundant. I will delete it in v3.
Oh, no need to delete it. Just change "should not" to "should" :).
I misunderstand the check due to this typo.
--
Xi Ruoyao <xry...@xry111.site>
School of Aerospace Science and Technology, Xidian University
