On Mon, 3 Feb 2025, Jakub Jelinek wrote:
> On Mon, Feb 03, 2025 at 03:30:41PM +0100, Richard Biener wrote:
> > The following checks we have a scalar int shift mode before
> > enforcing it. As AVR shows the mode can be a signed _Accum mode
> > as well.
> >
> > Bootstrap and regtest pending on x86_64-unknown-linux-gnu.
> >
> > OK if that succeeds?
> >
> > Thanks,
> > Richard.
> >
> > PR rtl-optimization/117611
> > * combine.cc (simplify_shift_const_1): Bail if not
> > scalar int mode.
>
> LGTM.
>
> > * gcc.target/avr/pr117611.c: New testcase.
>
> I don't see anything AVR specific here.
> Move to gcc.dg/fixed-point/pr117611.c ?
Done and pushed.
Richard.
> > new file mode 100644
> > index 00000000000..c76093f12d1
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/avr/pr117611.c
> > @@ -0,0 +1,7 @@
> > +/* { dg-do compile } */
> > +/* { dg-options "-Os" } */
> > +
> > +_Accum acc1 (_Accum x)
> > +{
> > + return x << 16;
> > +}
> > --
> > 2.43.0
>
> Jakub
>
>
--
Richard Biener <rguent...@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)
