On Fri, Jan 31, 2025 at 09:07:52AM +0100, Richard Biener wrote:
> The bug clearly shows that r8-4385-ga297ccb52e0c89 was wrong in
> enabling handling of address-space qualification as DWARF type
> qualifiers as the code isn't prepared to it actually be not handled
> and ends up changing a lesser qualified (without address-space)
> type DIE in ways tripping asserts. The following reverts that
> part which then causes the DIE for the same type with address-space
> qualifiers removed to be re-used since there's currently no code
> to encode address-spaces within dwarf2out.cc or in the DWARF spec.
>
> r8-4385-ga297ccb52e0c89 did not come with a testcase nor a good
> description of the bug fixed - I've verified const qualification
> mixed with address-spaces creates the expected DWARF.
>
> Bootstrap and regtest ongoing on x86_64-unknown-linux-gnu.
>
> OK for trunk? (I don't plan to backport, the bug points out a
> checking ICE only)
>
> PR debug/100530
> * dwarf2out.cc (modified_type_die): Do not claim we handle
> address-space qualification with dwarf_qual_info[].
>
> * gcc.target/i386/pr100530.c: New testcase.
Ok.
Jakub
