On Sun, Dec 22, 2024 at 08:59:00PM -0300, Alexandre Oliva wrote: > Hello, Dimitar, > > On Dec 22, 2024, Dimitar Dimitrov <dimi...@dinux.eu> wrote: > > > On Sat, Dec 21, 2024 at 02:28:33AM -0300, Alexandre Oliva wrote: > >> On Dec 20, 2024, Jakub Jelinek <ja...@redhat.com> wrote: > >> > >> > On Wed, Dec 18, 2024 at 12:59:11AM -0300, Alexandre Oliva wrote: > >> >> * gcc.dg/field-merge-16.c: New. > >> > >> > Note the test FAILs on i686-linux or on x86_64-linux with -m32. > >> > >> Also fixed herein. > > Since the second patch adjusted one of the tests submitted in the first > patch, I'm holding off from installing the second until the first one > (URL below) is (hopefully) approved. > https://gcc.gnu.org/pipermail/gcc-patches/2024-December/672161.html > > >> Regstrapped on x86_64-linux-gnu. I'd appreciate if someone who can test > >> AVR and PRU would confirm that it fixes all field-merge-* failures. Ok > >> to install? > > > All failures are now fixed for PRU: > > make check-gcc-c RUNTESTFLAGS="--target_board=pru-sim > > dg.exp=field-merge-*.c" > > # of expected passes 36 > > Thanks! > > > But several failures remain for AVR: > > FAIL: gcc.dg/field-merge-1.c (test for excess errors) > > FAIL: gcc.dg/field-merge-1.c execution test > [...] > > > I've attached the test log for AVR. > > Thanks, that was useful, if a little embarrasing (for my not realizing > that narrower int types would require explicit truncation of wide > constants ;-) > > > The tests seem to rely on int being at least 32 bits > > That reliance was accidental, rather than essential, so adding explicit > casts should be enough to avoid warnings and runtime errors. > > > > Explicitly convert constants to the desired types, so as to not elicit > warnings about implicit truncations, nor execution errors, on targets > whose ints are narrower than 32 bits. > > Tested (on top of the previous patches) on x86_64-linux-gnu, and on > avr-none, inspecting gcc.log and disregarding linker errors for not > finding -lm and -lc. I'd appreciate confirmation about execution tests > on avr (thanks in advance). Ok to install?
There are no failing tests now for AVR: make check-gcc-c RUNTESTFLAGS="--target_board=atmega128-sim dg.exp=field-merge-*.c" # of expected passes 36 Thanks, Dimitar
