Hi,

This is the 4th ping of the middle end review for the patch set.

Really appreciate any comments and suggestions from Middle-end reviewer
on this patch (the diagnostic part of the patch has been reviewed and approved 
already).

As I know, Kees and Sam have been using this option for a while and both found 
very helpful.

Could you please take a look and let me know any issue in the patch?

Thanks a lot!

The latest version of(4th version) is:
https://gcc.gnu.org/pipermail/gcc-patches/2024-November/667613.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-November/667614.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-November/667615.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-November/667616.html

Qing

Begin forwarded message:

From: Sam James <s...@gentoo.org>
Subject: Re: 3rd Ping: [Middle-end][PATCH v4 0/3][RFC]Provide more contexts for 
-Warray-bounds and -Wstringop-* warning messages
Date: December 6, 2024 at 13:32:55 EST
To: Qing Zhao <qing.z...@oracle.com>, Jeff Law <jeffreya...@gmail.com>
Cc: richard Biener <richard.guent...@gmail.com>, GCC Patches 
<gcc-patches@gcc.gnu.org>, kees Cook <keesc...@chromium.org>, Andrew Pinski 
<pins...@gmail.com>, David Malcolm <dmalc...@redhat.com>

Qing Zhao <qing.z...@oracle.com> writes:

This is the 3rd ping of the Middle-end review for this patch.


Jeff, would you be able to take a look? (In part because I know
you've had a lot of comments and feedback on the middle-end warnings
before). The diagnostics bits are OK'd already.

I've been running this on distro builds for a few months now and had
great results with it so far (including finding some real bugs in
packages that I'd previously dismissed as probable-FPs).

I can also chuck it in to our general testing builds if it'd help any.

Thanks a lot!

Qing

On Nov 26, 2024, at 10:30, Qing Zhao <qing.z...@oracle.com> wrote:

Another ping on the Middle-end review of this patch.

This patch has been waiting for the middle-end review for a long time.

Please review it and provide any feedback, I believe that this should be a nice 
improvement to GCC diagnostic in general.

Thanks.

Qing

On Nov 15, 2024, at 10:34, Qing Zhao <qing.z...@oracle.com> wrote:

Gentle ping on the middle-end review for this patch.

There are two parts of this patch:

1. Diagnostic part (Part 2), which has been reviewed by David;
2. Middle end part (Part 1 and 3), mainly on the copy_history information 
collection during transformation.

Thanks,

Qing


On Nov 5, 2024, at 11:31, Qing Zhao <qing.z...@oracle.com> wrote:

Hi,

This is the 4th version of the patch for fixing PR109071.

Compared to the 3nd version:
https://gcc.gnu.org/pipermail/gcc-patches/2024-October/666870.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-October/666872.html
https://gcc.gnu.org/pipermail/gcc-patches/2024-October/666871.html

The major improvements to this patch are:

1. Divide the patch into 3 parts:
Part 1: Add new data structure move_history, record move_history during
        transformation;
Part 2: In warning analysis, Use the new move_history to form a rich
        location with a sequence of events, to report more context info
        of the warnings.
Part 3: Add debugging mechanism for move_history.

2. Major change to the above Part 2, completely rewritten based on David's
new class lazy_diagnostic_path.

3. Fix all issues identied By Sam;
A. fix PR117375 (Bug in tree-ssa-sink.cc);
B. documentation clarification;
C. Add all the duplicated PRs in the commit comments;

4. Bootstrap GCC with the new -fdiagnostics-details on by default (Init (1)).
exposed some ICE similar as PR117375 in tree-ssa-sink.cc, fixed.


bootstrapping and regression testing on both x86 and aarch64.

Please let me know any comment and suggestion.

Thanks.

Qing
Qing Zhao (3):
Provide more contexts for -Warray-bounds, -Wstringop-* warning
messages due to code movements from compiler transformation (Part 1)
[PR109071,PR85788,PR88771,PR106762,PR108770,PR115274,PR117179]
Provide more contexts for -Warray-bounds, -Wstringop-* warning
messages due to code movements from compiler transformation (Part 2)
[PR109071,PR85788,PR88771,PR106762,PR108770,PR115274,PR117179]
Provide more contexts for -Warray-bounds, -Wstringop-* warning
messages due to code movements from compiler transformation (Part 3)
[PR109071,PR85788,PR88771,PR106762,PR108770,PR115274,PR117179]





Reply via email to