On 14/11/2024 10:41, Christophe Lyon wrote:
Remove floating-point condition from mve_vec_extract_sext_internal and
mve_vec_extract_zext_internal, since the MVE_2 iterator does not
include any FP mode.

gcc/ChangeLog:

        * config/arm/mve.md (mve_vec_extract_sext_internal): Fix
        condition.
        (mve_vec_extract_zext_internal): Likewise.
---
  gcc/config/arm/mve.md | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/config/arm/mve.md b/gcc/config/arm/mve.md
index a0a59da4040..70f6ec6c2cc 100644
--- a/gcc/config/arm/mve.md
+++ b/gcc/config/arm/mve.md
@@ -4191,7 +4191,7 @@ (define_insn "*mve_vec_extract_sext_internal<mode>"
       (match_operand:MVE_2 1 "s_register_operand" "w")
       (parallel [(match_operand:SI 2 "immediate_operand" "i")]))))]
    "(TARGET_HAVE_MVE && VALID_MVE_SI_MODE (<MODE>mode))
-   || (TARGET_HAVE_MVE_FLOAT && VALID_MVE_SF_MODE (<MODE>mode))"
+   "

I'd just put the closing quote on the previous line. It looks odd dangling like that.
  {
    if (BYTES_BIG_ENDIAN)
      {
@@ -4210,7 +4210,7 @@ (define_insn "*mve_vec_extract_zext_internal<mode>"
       (match_operand:MVE_2 1 "s_register_operand" "w")
       (parallel [(match_operand:SI 2 "immediate_operand" "i")]))))]
    "(TARGET_HAVE_MVE && VALID_MVE_SI_MODE (<MODE>mode))
-   || (TARGET_HAVE_MVE_FLOAT && VALID_MVE_SF_MODE (<MODE>mode))"
+   "
Same

  {
    if (BYTES_BIG_ENDIAN)
      {

Otherwise OK.

R.

Reply via email to