пт, 6 дек. 2024 г. в 19:32, Vladimir Makarov <vmaka...@redhat.com>: > > The proposed patch can be a fix and you can commit it. The only request is > not to close PR for now. > > LRA rematerialization sub-pass rematerializes insn containing only pseudos > assigned to hard regs and should not change live-range of spilling pseudos. > So sentence "Rematerialization sometimes can be like spilling pseudos into > registers." should be wrong for LRA design. > > Unfortunately, spilling of p184 happens after several sub-passes including > rematerialization. That is because p184 was assigned to non-eliminable reg > 29. > > I think the full and correct solution would be a modification of > lra_need_for_spills_p function to deal with pseudos assigned to > non-eliminable reg. > > I'll work on such solution on the next week. But I again you can commit your > patch right now as a partial solution. > > Thank you for working on the PR and making a progress on it.
Committed 279b3c71702 Denis
