Hi Carl,
在 2024/10/3 23:11, Carl Love 写道:
> GCC maintainers:
>
> The builtins-1-10-runnable.c has the debugging inadvertently enabled. The
> test uses #ifdef to enable/disable the debugging. Unfortunately, the #define
> DEBUG was set to 0 to disable debugging and enable the call to abort in case
> of error. The #define should have been removed to disable debugging.
> Additionally, a change in the expected output which was made for testing
> purposes was not removed. Hence, the test is printing that there was an
> error not calling abort. The result is the test does not get reported as
> failing.
>
> This patch removes the #define DEBUG to enable the call to abort and restores
> the expected output to the correct value. The patch was tested on a Power 10
> without the #define DEBUG to verify that the test does fail with the
> incorrect expected value. The correct expected value was then restored. The
> test reports 19 expected passes and no errors.
>
> Please let me know if this patch is acceptable for mainline. Thanks.
>
> Carl
>
>
> ---------------------------------------------------------------------------------------
>
> rs6000, fix test builtins-1-p10-runnable.c
>
> The test has two issues:
>
> 1) The test should generate execute abort() if an error is found.
> However, the test contains a #define 0 which actually enables the
> error prints not exectuting void() because the debug code is protected
> by an #ifdef not #if. The #define DEBUG needs to be removed to so the
> test will abort on an error.
>
> 2) The vec_i_expected output was tweeked to test that it would fail.
> The test value was not removed.
>
> By removing the #define DEBUG, the test fails and reports 1 failure.
> Removing the intentionally wrong expected value results in the test
> passing with no errors as expected.
>
> gcc/testsuite/ChangeLog:
> * gcc.target/powerpc/builtins-1-p10-runnable.c: Remove #define
> DEBUG. Replace vec_i_expected value with correct value.
Nit: Three more spaces before "Replace", so s/ //.
OK for trunk with this tweaked, thanks!
BR,
Kewen
> ---
> gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c
> b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c
> index 222c8b3a409..3e8a1c736e3 100644
> --- a/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c
> +++ b/gcc/testsuite/gcc.target/powerpc/builtins-1-p10-runnable.c
> @@ -25,8 +25,6 @@
> #include <math.h>
> #include <altivec.h>
>
> -#define DEBUG 0
> -
> #ifdef DEBUG
> #include <stdio.h>
> #endif
> @@ -281,8 +279,7 @@ int main()
> /* Signed word multiply high */
> i_arg1 = (vector int){ 2147483648, 2147483648, 2147483648, 2147483648 };
> i_arg2 = (vector int){ 2, 3, 4, 5};
> - // vec_i_expected = (vector int){-1, -2, -2, -3};
> - vec_i_expected = (vector int){1, -2, -2, -3};
> + vec_i_expected = (vector int){-1, -2, -2, -3};
>
> vec_i_result = vec_mulh (i_arg1, i_arg2);
>
