Re: [Patch] libgomp/plugin/plugin-gcn.c: async-queue init - fix function-return type and fail fatally

[Andrew Stubbs]

On 11/18/24 13:23, Tobias Burnus wrote:

This fixes a C23 error, causing a build fail: 'false'
should have been 'NULL'.

The NULL value is not really handled as the code calling

maybe_init_omp_async assumes that agent->omp_async_queue can be dereferenced. Hence, besides fixing the false/NULL issue, it switches to a 'fatal' error. Comments before I commit it after lunch? Tobias

LGTM.

Andrew