A kind remind/ping on the patch. Kind regards, Aleksandar Rakić
________________________________________ From: Aleksandar Rakic <[email protected]> Sent: Thursday, October 31, 2024 12:46 PM To: [email protected] Cc: [email protected]; Djordje Todorovic; Jovan Dmitrovic Subject: Re: [Bug tree-optimization/109429] [PATCH v2] ivopts: fixed complexities A kind remind/ping on the patch. Kind regards, Aleksandar Rakić ________________________________________ From: Aleksandar Rakic <[email protected]> Sent: Wednesday, October 9, 2024 2:15 PM To: [email protected] Cc: [email protected]; Djordje Todorovic; Jovan Dmitrovic Subject: Re: [Bug tree-optimization/109429] [PATCH v2] ivopts: fixed complexities A kind remind/ping on the patch. Kind regards, Aleksandar Rakić ________________________________________ From: Aleksandar Rakic <[email protected]> Sent: Wednesday, September 25, 2024 5:32 PM To: [email protected] Cc: [email protected]; Djordje Todorovic; Jovan Dmitrovic Subject: [Bug tree-optimization/109429] [PATCH v2] ivopts: fixed complexities Hi, I think I managed to fix indentation from the previous version. When comparing the tables showing the candidates for the group 1 before and after applying this patch, it can be observed that complexities for the candidates where the computation depends on the invariant expressions or the invariant variables should be at least one, which aligns with the approach used in the commit c2b64ce. ===== Before this patch ===== Group 1: cand cost compl. inv.expr. inv.vars 1 11 0 5; NIL; 2 11 0 6; NIL; 4 8 0 7; NIL; 5 9 0 8; NIL; 6 1 0 NIL; NIL; 7 1 1 NIL; NIL; 9 7 0 5; NIL; ===== Before this patch ===== ===== After this patch ===== Group 1: cand cost compl. inv.expr. inv.vars 1 11 2 4; NIL; 2 11 1 4; NIL; 4 8 1 5; NIL; 5 8 2 6; NIL; 6 1 0 NIL; NIL; 7 1 1 NIL; NIL; 9 7 2 4; NIL; ===== After this patch ===== Hence, if the invariant expressions or the invariant variables are used when representing use with candidate, the complexity should be larger for more complex expressions, so it is incremented by one. I am not sure whether inv_present could be expressed as parts. Regards, Aleksandar
