On 11/15/24 3:25 AM, Robin Dapp wrote:
So this is really the biggest question in my mind. When we kicked this
around in the patchwork meeting several weeks ago I got the impression
Robin had a correctness concern with this code. Robin, do you remember
what had you worried?
Unfortunately I haven't managed to get back to this in weeks now.
I vaguely recall that it was something related to "changed" as well but
it looks you have that covered already. I'd say let's go ahead with
that fixed.
Well, I threw it into my tester. Both riscv32-elf and riscv64-elf
should run in about an hour depending on which server picks up the
build. riscv32-elf has been running for 12+ hours, and riscv64-elf
finished after 8 hours. It looks like the latter likely failed a
number of vector tests due to compiler timeouts. So likely culprit is
that "changed" part of the updated patch.
Just to be sure, I pulled out just that part and sure enough rv64
competed in 45 minutes. Anyway, time to proceed to debugging as it
clearly can't go in as-is.
jeff
