On Tue, Nov 5, 2024 at 4:53 AM Andrew Carlotti <andrew.carlo...@arm.com> wrote: > > This test started failing on aarch64 after 0cfc9c95 in 2023 ("Phi > analyzer - Initialize with range instead of a tree."). > > The only change visible in the pass dumps prior to thread2 is the upper > bounds of some ranges are reduced from +INF to 7, consistent with the > bitamsk information. After thread2, there are changes in the control > flow, but only affecting edges that are obviously never taken (from > basic blocks 6 through 12). These are cleaned up in the following pass, > but the final codegen remains different. > > There isn't anything obviously wrong with the change in dump output, so > let's just update the test expectations (as has happened previously > here). > > I think this is an obvious patch, but I'll wait a few days before committing.
This was recorded as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112376 . I think it would be a good idea to mention the bug # in the commit too. And maybe backport to GCC 14. Thanks, Andrew > > gcc/testsuite/ChangeLog: > > * gcc.dg/tree-ssa/ssa-dom-thread-7.c: Update expectation. > > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-thread-7.c > b/gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-thread-7.c > index > 47b8fdfa29a585c68f398b7bcfe8f566be211ddf..d84aceebc5d02e494422348bc67990f0ec883d33 > 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-thread-7.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-thread-7.c > @@ -12,7 +12,7 @@ > jump threading opportunities. Skip the later tests on aarch64. */ > /* { dg-final { scan-tree-dump-not "Jumps threaded" "dom3" { target { ! > aarch64*-*-* } } } } */ > /* { dg-final { scan-tree-dump "Jumps threaded: 9" "thread2" { target { ! > aarch64*-*-* } } } } */ > -/* { dg-final { scan-tree-dump "Jumps threaded: 18" "thread2" { target { > aarch64*-*-* } } } } */ > +/* { dg-final { scan-tree-dump "Jumps threaded: 17" "thread2" { target { > aarch64*-*-* } } } } */ > > enum STATE { > S0=0,