Re: [PATCH 1/6] Thread pointer built-in functions, core parts

[Richard Sandiford]

Hi Chung-Lin,

Chung-Lin Tang <clt...@codesourcery.com> writes:
> Core parts adding the new hooks. BUILT_IN_THREAD_POINTER and
> BUILT_IN_SET_THREAD_POINTER are different hooks, as some targets only
> implement one of them (thread pointer read).

Thanks a lot for doing this.  It looks great to me, although I can't
approve it.  Only thing I could see was:

> +rtx
> +default_expand_builtin_thread_pointer (rtx target ATTRIBUTE_UNUSED)
> +{
> +  sorry ("__builtin_thread_pointer() not available for this target");
> +  return NULL;
> +}
> +
> +void
> +default_expand_builtin_set_thread_pointer (rtx val ATTRIBUTE_UNUSED)
> +{
> +  sorry ("__builtin_set_thread_pointer() not available for this target");
> +}

Function names should be quoted by %< %>.  But maybe we can save the
translators some work and use:

  sorry ("%qs is not available for this target", "__builtin_thread_pointer()");
...
  sorry ("%qs is not available for this target",
         "__builtin_set_thread_pointer()");

instead.  I'm no expert on the diagnostic stuff though.

Hope it goes in!

Thanks,
Richard