On Sun, 2024-10-13 at 20:44 -0400, James K. Lowden wrote:
/* snip */
> In testing the patch with "git am"
Please also use "git gcc-verify". See below for the incorrect changelog
which would be caught by the command.
> I got a warning about a blank line
> at EOF, but I couldn't figure out where it was, or if it mattered.
>
> --jkl
>
> From 06a93d00f4433fb61ff9611c6e945a3a11c89479bld.patch 4 Oct 2024
> 12:01:22 -0400
> From: "James K. Lowden" <jklow...@symas.com>
> Date: Mon 14 Oct 2024 03:25:23 PM EDT
> Subject: [PATCH] Add 'cobol' to 9 files
>
> * Makefile.def: Add libgcobol module and cobol language.
> * configure: Add libgcobol module and cobol language.
> * configure.ac: Add libgcobol module and cobol language.
> * gcc/cobol/LICENSE: Add gcc/cobol/LICENSE
> * gcc/cobol/Make-lang.in: Add libgcobol module and cobol
> language.
> * gcc/cobol/config-lang.in: Add libgcobol module and cobol
> language.
> * gcc/cobol/lang.opt: Add libgcobol module and cobol
> language.
> * gcc/common.opt: Add libgcobol module and cobol language.
The changelog is not formatted correctly. gcc/ has its own changelog.
And gcc/cobol should have its own changelog too, like all other
frontends.
i.e. Something like
ChangeLog:
* Makefile.def: ...
* configure.ac: ...
* configure: Regenerate
gcc/ChangeLog:
* common.opt: ...
gcc/cobol/ChangeLog:
* lang.opt: ...
* ...
And you need to add a stub gcc/cobol/ChangeLog before the patch, like
commit 24ff0b3e0c41e3997fb4c11736b8a412afbaadf3 "Add stub
'gcc/rust/ChangeLog'".
--
Xi Ruoyao <xry...@xry111.site>
School of Aerospace Science and Technology, Xidian University
