On 18/10/2024 16:53, Andre Vieira (lists) wrote: > Sorry for the delay, some other work popped up in between and this had some > latent issues. They should all be addressed now in this new patch. > > > When not dealing with the special armv8.1-m.main conditional instructions > case make sure it uses the default_noce_conversion_profitable_p call to > determine whether the sequence is cost effective. > > Also make sure arm_noce_conversion_profitable_p accepts vsel<cond> patterns > for Armv8.1-M Mainline targets. > > gcc/ChangeLog: > > * config/arm/arm.cc (arm_noce_conversion_profitable_p): Call > default_noce_conversion_profitable_p when not dealing with the > armv8.1-m.main special case. > (arm_is_vsel_fp_insn): New function. > > > Regression tested on arm-none-eabi with -mcpu=cortex-m3 and > -mcpu=cortex-m55/-mfloat-abi=hard. > > OK for trunk? >
This is OK, but please can you add a comment to arm_is_vsel_fp_insn explaining that it is a heuristic that cannot lead to incorrect code (because validation is done elsewhere). R.
