On Wed, 23 Oct 2024 at 19:44, Jonathan Wakely <jwak...@redhat.com> wrote: > > On Wed, 23 Oct 2024 at 19:41, Jonathan Wakely <jwak...@redhat.com> wrote: > > > > On Wed, 23 Oct 2024 at 16:02, Jason Merrill <ja...@redhat.com> wrote: > > > > > > Should there also/instead be a test with <stdalign.h>? > > > > We don't usually (or ever?) bother to test the .h versions of headers. > > For these ones that are deprecated it probably makes sense to do so, > > because <stdalign.h> isn't deprecated, only <cstdalign>. So we should > > ensure that the .h forms work fine without diagnostics even in C++17 > > and later. > > I'll add more tests. > > But I think it makes sense to do that as part of a follow-up commit > where I deprecate <cstdalign>.
Here's a preview of that follow-up, without the new tests I need to add: https://forge.sourceware.org/gcc/gcc-TEST/pulls/4