On Wed, 16 Oct 2024, Jakub Jelinek wrote: > Hi! > > Jonathan mentioned an unnamed static analyzer reported issue in > c_finish_bc_name. > It is actually a false positive, because the construction of the > loop_names vector guarantees that the last element of the vector > (if the vector is non-empty) always has either > C_DECL_LOOP_NAME (l) or C_DECL_SWITCH_NAME (l) (or both) flags > set, so c will be always non-NULL after the if at the start of the > loops. > The following patch is an attempt to help those static analyzers > (though dunno if it actually helps), by adding a checking assert. > > Tested on x86_64-linux, ok for trunk? > > 2024-10-16 Jakub Jelinek <ja...@redhat.com> > > * c-decl.cc (c_get_loop_names): Add checking assert that > c is non-NULL in the loop. > (c_finish_bc_name): Likewise.
OK. -- Joseph S. Myers josmy...@redhat.com
