On Sat, Jul 7, 2012 at 9:48 PM, Steven Bosscher <stevenb....@gmail.com> wrote:
> On Fri, Jul 6, 2012 at 10:41 AM, Richard Guenther
> <richard.guent...@gmail.com> wrote:
>> Wow ;) I agree about the set_loop_copy/get_loop_copy change - I'd simply
>> postpone it with a comment why cfgloop.h is needed and investigate the
>> pointer-map idea.
>
> Yes, that was my plan too. pointer-map won't work, BTW, but maybe a
> splay tree or a new data structure to hold integer pairs.
>
>
>> Generally I think dump_* routines should work even when cfun is not the
>> function we dump an edge for. Thus,
>>
>> - /* both ENTRY_BLOCK_PTR & EXIT_BLOCK_PTR depend upon cfun. */
>> - if (cfun && side == ENTRY_BLOCK_PTR)
>> + if (side == ENTRY_BLOCK_PTR)
>> fputs (" ENTRY", file);
>> - else if (cfun && side == EXIT_BLOCK_PTR)
>> + else if (side == EXIT_BLOCK_PTR)
>> fputs (" EXIT", file);
>>
>> should instead test side->index == ENTRY_BLOCK / EXIT_BLOCK.
>
> Done.
>
>
>> Otherwise the patch looks really good - best if teamed with updating
>> doc/cfg.texi ;)
>
> Ouch, cfg.texi is not very up-to-date. I've tried to fix most things I
> noticed, but it could still use some editing...
> (Reminds me: Did you update loop.texi for your work on preserving loops? ;-) )
Eh ... got me ;)
> Bootstrapped and tested on powerpc64-unknown-linux-gnu.
> OK for trunk?
Ok!
Thanks,
Richard.
> Ciao!
> Steven
