On 10/9/24 7:06 PM, Patrick Palka wrote:
On Wed, 9 Oct 2024, Jason Merrill wrote:
Tested x86_64-pc-linux-gnu, will apply to trunk with the rest of the patch
series.
-- 8< --
At this point there doesn't seem to be much reason not to have modules
support enabled by default in C++20, and it's good get more test coverage to
find corner case bugs like some I fixed recently.
Not sure how much we care about PCH anymore, but won't this effectively
disable PCH in C++20 and later due to
/* C++ modules and PCH don't play together. */
if (flag_modules)
return 2;
in c_common_valid_pch?
Yes; switching from PCH to C++20 header units should be fairly seamless.
But that's why I add -fno-modules for the PCH tests.
Jason
