On Fri, Oct 4, 2024 at 9:25 PM Andre Vieira (lists) <andre.simoesdiasvie...@arm.com> wrote: > > Hi, > > The patch for 'arm: Fix missed CE optimization for armv8.1-m.main [PR > 116444]' introduced regressions with arm targets that used 'noce' before. > This is because it would approve all noce optimisations without using > the default cost check. Not sure why this didn't show up in my original > testing, I suspect you need to test this for a set of specific targets > like Torbjorn did, thank you for pointing these issues out to me. > > Could I ask you to rerun them with this patch? I'll try to do that > locally too. > > Happy to receive reviews, but I'm waiting for Torbjorn and my own > testing to complete before committing. > > When not dealing with the special armv8.1-m.main conditional > instructions case > make sure it uses the default_noce_conversion_profitable_p call to determine > whether the sequence is cost effective. >
Ok if no regressions. Ramana > gcc/ChangeLog: > > > PR target/116444 > * config/arm/arm.cc (arm_noce_conversion_profitable_p): Call > default_noce_conversion_profitable_p when not dealing with the > armv8.1-m.main conditional instructions special cases.
