Thomas Schwinge <tschwi...@baylibre.com> writes:
> Hi Andrew, Sam!
>
> On 2024-09-20T14:21:33-0700, Andrew Pinski <pins...@gmail.com> wrote:
>> On Fri, Sep 20, 2024 at 1:53 AM Thomas Schwinge <tschwi...@baylibre.com>
>> wrote:
>>> On 2024-09-20T05:12:19+0100, Sam James <s...@gentoo.org> wrote:
>>> > In this case, they were all harmless in reality (no diff in test logs).
>>>
>>> > -/* { dg-do compile ) */
>>> > +/* { dg-do compile } */
>>>
>>> DejaGnu directives are matched by '{ dg-[...] }' (simplified; see
>>> '/usr/share/dejagnu/dg.exp:dg-get-options' for the details), so your
>>> changes did not "fix dejagnu directive syntax", but rather fix whitespace
>>> around DejaGnu directives. ;-P (Thanks either way!)
>>
>> I think you missed that in these cases it was `)` vs `}` . yes some
>> fonts it is sometimes hard to tell especially it is on different lines
>> but they are different characters.
>
> Indeed, you're absolutely right, thanks for pointing that out, Andrew!
> Sam, I apologize -- you did "fix dejagnu directive syntax" after all!
> I'll blame it 1/3 on the font display (..., but now I do see it, of
> course...), 1/3 on me not paying carful attention, and 1/3 on me not
> paying carful attention due to having a cold after return from the
> GNU Tools Cauldron 2024 yet trying to be funny.
>
> ..., and now let me please crawl back under my stone, and hide in shame.
No, I appreciate people checking carefully! Just keep this in mind for
when I inevitably make a mistake next and go easy on me ;)
Cheers!
sam
